Update steamworks to 1.60#5
Conversation
roblabla
force-pushed
the
update-steamworks
branch
2 times, most recently
from
6a9a561 to
cbd0381
Compare
Wartori54
left a comment
Wartori54
left a comment
There was a problem hiding this comment.
This project's goal is to avoid having binary blobs in the repository as much as possible. With steam_api it still has to be shipped this way, but for Steamworks.NET it should be built in CI (just like the other C# projects) instead of being bundled like steam_api.
In this case, though, it would be also fine if the release from the Steamworks.NET repository is pulled and the binaries in there used in CI.
Make sure to note this on "Open-Source Libraries" part in the README.md
roblabla
force-pushed
the
update-steamworks
branch
6 times, most recently
from
66bd91f to
2721040
Compare
|
I added a Steamworks.NET submodule in the source directory (initialized at 2024.8.0), added it to the README, and built it in CI. |
|
Since the native libraries are already vendored by the Steamworks.NET project, I think we should just copy them from their repo to avoid the possibility of the versions getting desynced. |
|
Ah, I hadn't realized that they were, but you're right. They're in the com.rlabrecque.steamworks.net/Plugins folder. I'll adapt the CI to copy the binaries from there. |
roblabla
force-pushed
the
update-steamworks
branch
from
2721040 to
b77df01
Compare
|
All fixed, we now copy the steam_api files found within the Steamworks.NET submodule, ensuring they are kept in sync. |
Wartori54
left a comment
Wartori54
left a comment
There was a problem hiding this comment.
LGTM other than that minor nitpick
This, in combination with an update of Steamworks.NET, will allow modders to use the newer features offered by the latest version of the Steamworks SDK.
roblabla
force-pushed
the
update-steamworks
branch
from
b77df01 to
c108ad1
Compare
psyGamer
left a comment
psyGamer
left a comment
There was a problem hiding this comment.
Also LGTM.
Tho note that the double-space in MarkDown files indicate a new line and are not incorrect trailing whitespace. I've just fixed it myself since its trivial, but it would be good to remember in the future.
|
Oh, that's my editor remoing trailing whitespace. I should probably configure that to ignore Markdown files ^^' |
3 participants
This, in combination with an update of Steamworks.NET in Everest, will allow modders to use the newer features offered by the latest version of the Steamworks SDK.
This removes CSteamworks.dll, as it is unnecessary with the newer versions of Steamworks.NET/steam_api, as steam_api provides its own C wrapper nowadays.